From 570d84b2cb92810d9777e70f2595826a1218193d Mon Sep 17 00:00:00 2001 From: Charles Queiroz Date: Thu, 19 Dec 2024 18:41:37 +0000 Subject: [PATCH 1/3] DAT-18731 - Resolving the /null problem when not finding the createTable.aql file And also solving the problem of not cleaning the files generated after finishing the tests. --- pom.xml | 8 +++++++- .../ext/databricks/AdvancedExtensionHarnessTestSuite.java | 3 ++- .../expectedChangeLog/databricks/createTable.sql | 1 - .../expectedSql/databricks/createTable.sql | 1 + 4 files changed, 10 insertions(+), 3 deletions(-) delete mode 100644 src/test/resources/liquibase/harness/generateChangelog/expectedChangeLog/databricks/createTable.sql create mode 100644 src/test/resources/liquibase/harness/generateChangelog/expectedSql/databricks/createTable.sql diff --git a/pom.xml b/pom.xml index a9f8e606..dece3470 100644 --- a/pom.xml +++ b/pom.xml @@ -63,7 +63,7 @@ true src/main/java src/test - 1.0.10 + 1.1.0-SNAPSHOT 5.11.4 1.11.4 5.14.2 @@ -137,6 +137,12 @@ ${mockito.version} test + + org.junit.platform + junit-platform-suite-api + 1.11.3 + test + diff --git a/src/test/java/liquibase/ext/databricks/AdvancedExtensionHarnessTestSuite.java b/src/test/java/liquibase/ext/databricks/AdvancedExtensionHarnessTestSuite.java index 4031bf0f..64a87383 100644 --- a/src/test/java/liquibase/ext/databricks/AdvancedExtensionHarnessTestSuite.java +++ b/src/test/java/liquibase/ext/databricks/AdvancedExtensionHarnessTestSuite.java @@ -1,9 +1,10 @@ package liquibase.ext.databricks; import liquibase.harness.AdvancedHarnessSuite; +import liquibase.harness.generateChangelog.GenerateChangelogTest; import liquibase.harness.snapshot.SnapshotObjectTests; import org.junit.platform.suite.api.SelectClasses; -@SelectClasses({SnapshotObjectTests.class}) +@SelectClasses({SnapshotObjectTests.class, GenerateChangelogTest.class}) public class AdvancedExtensionHarnessTestSuite extends AdvancedHarnessSuite { } diff --git a/src/test/resources/liquibase/harness/generateChangelog/expectedChangeLog/databricks/createTable.sql b/src/test/resources/liquibase/harness/generateChangelog/expectedChangeLog/databricks/createTable.sql deleted file mode 100644 index b06ec0fa..00000000 --- a/src/test/resources/liquibase/harness/generateChangelog/expectedChangeLog/databricks/createTable.sql +++ /dev/null @@ -1 +0,0 @@ -CREATE TABLE test_table_xml (test_column INT); \ No newline at end of file diff --git a/src/test/resources/liquibase/harness/generateChangelog/expectedSql/databricks/createTable.sql b/src/test/resources/liquibase/harness/generateChangelog/expectedSql/databricks/createTable.sql new file mode 100644 index 00000000..b696e7c9 --- /dev/null +++ b/src/test/resources/liquibase/harness/generateChangelog/expectedSql/databricks/createTable.sql @@ -0,0 +1 @@ +CREATE TABLE test_table_xml (test_column INT) USING delta TBLPROPERTIES('delta.feature.allowColumnDefaults' = 'supported', 'delta.columnMapping.mode' = 'name', 'delta.enableDeletionVectors' = true); \ No newline at end of file From 31758742115c2f0f4cbc2a6381cc8abe11f14e7f Mon Sep 17 00:00:00 2001 From: Charles Queiroz Date: Thu, 19 Dec 2024 20:09:14 +0000 Subject: [PATCH 2/3] DAT-18731 - Fixing pom version --- pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index dece3470..793554f5 100644 --- a/pom.xml +++ b/pom.xml @@ -63,7 +63,7 @@ true src/main/java src/test - 1.1.0-SNAPSHOT + 1.0.10 5.11.4 1.11.4 5.14.2 From c569dec44a679eb2f7338ee6a369040574c83bd8 Mon Sep 17 00:00:00 2001 From: Charles Queiroz Date: Fri, 20 Dec 2024 15:36:39 +0000 Subject: [PATCH 3/3] DAT-18731 - Removing dependency not necessary --- pom.xml | 6 ------ .../ext/databricks/AdvancedExtensionHarnessTestSuite.java | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/pom.xml b/pom.xml index 793554f5..a9f8e606 100644 --- a/pom.xml +++ b/pom.xml @@ -137,12 +137,6 @@ ${mockito.version} test - - org.junit.platform - junit-platform-suite-api - 1.11.3 - test - diff --git a/src/test/java/liquibase/ext/databricks/AdvancedExtensionHarnessTestSuite.java b/src/test/java/liquibase/ext/databricks/AdvancedExtensionHarnessTestSuite.java index 64a87383..05c534f4 100644 --- a/src/test/java/liquibase/ext/databricks/AdvancedExtensionHarnessTestSuite.java +++ b/src/test/java/liquibase/ext/databricks/AdvancedExtensionHarnessTestSuite.java @@ -5,6 +5,6 @@ import liquibase.harness.snapshot.SnapshotObjectTests; import org.junit.platform.suite.api.SelectClasses; -@SelectClasses({SnapshotObjectTests.class, GenerateChangelogTest.class}) +@SelectClasses({SnapshotObjectTests.class}) public class AdvancedExtensionHarnessTestSuite extends AdvancedHarnessSuite { }