From fbd23807ecca798add8ce4829deb4f0795640ba7 Mon Sep 17 00:00:00 2001 From: Alejandro Alvarez Date: Wed, 25 Oct 2023 13:08:08 +0200 Subject: [PATCH] Fix jacoco report paths 2 (#121) * fix(sonar-push.yml): update the action used to download test results artifact to use dawidd6/action-download-artifact@v2 feat(sonar-push.yml): add path parameter to specify the target directory for downloaded artifact * chore(sonar-push.yml): update Maven command to skip tests during package phase to improve build performance * fix(sonar-pull-request.yml): fix the variable name from sonar.login to sonar.token to correctly pass the Sonar token fix(sonar-push.yml): remove unnecessary path configuration for test-reports-jdk-17-ubuntu-latest job * chore(sonar-push.yml): remove unnecessary path configuration for test-reports-jdk-17-ubuntu-latest job --- .github/workflows/sonar-pull-request.yml | 2 +- .github/workflows/sonar-push.yml | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/sonar-pull-request.yml b/.github/workflows/sonar-pull-request.yml index 3ad3e3d5..5ac043fe 100644 --- a/.github/workflows/sonar-pull-request.yml +++ b/.github/workflows/sonar-pull-request.yml @@ -105,7 +105,7 @@ jobs: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} AWS_REGION: "us-east-1" run: | - mvn -B -Daws.region="us-east-1" -Dsonar.login=$SONAR_TOKEN \ + mvn -B -Daws.region="us-east-1" -Dsonar.token=$SONAR_TOKEN \ -Dsonar.pullrequest.key=${{ github.event.pull_request.number }} \ -Dsonar.pullrequest.branch=${{ github.event.pull_request.head.ref }} \ -Dsonar.pullrequest.base=${{ github.event.pull_request.base.ref }} \ diff --git a/.github/workflows/sonar-push.yml b/.github/workflows/sonar-push.yml index 9732c89b..08b1056c 100644 --- a/.github/workflows/sonar-push.yml +++ b/.github/workflows/sonar-push.yml @@ -60,7 +60,6 @@ jobs: workflow: test.yml name: test-reports-jdk-17-ubuntu-latest repo: ${{ github.repository }} - path: ./target if_no_artifact_found: warn workflow_conclusion: "" @@ -113,6 +112,6 @@ jobs: SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} AWS_REGION: "us-east-1" run: | - mvn -B -Daws.region="us-east-1" -Dsonar.login=$SONAR_TOKEN \ + mvn -B -Daws.region="us-east-1" -Dsonar.token=$SONAR_TOKEN \ -Dsonar.scm.revision=${{ github.event.pull_request.head.sha }} \ package -DskipTests sonar:sonar