Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue on liqo uninstallation #2821

Open
thisiskazem opened this issue Nov 21, 2024 · 2 comments · May be fixed by #2825
Open

Issue on liqo uninstallation #2821

thisiskazem opened this issue Nov 21, 2024 · 2 comments · May be fixed by #2825

Comments

@thisiskazem
Copy link

thisiskazem commented Nov 21, 2024 •
edited
Loading

Hello everyone.

I have a central kubernetes cluster implemented on OpenStack with 3 machines (1 server and 2 agents) with k3s installed on it using:
curl -sfL https://get.k3s.io | sh -s - server --disable traefik --node-external-ip <PUBLIC_IP_ADDRESS>

and an edge node which is a minipc with k3s installed using:
sudo curl -sfL https://get.k3s.io | INSTALL_K3S_EXEC="--disable traefik" sh -s - --write-kubeconfig-mode 644-

This is the installed version of liqo on both sides:
Screenshot from 2024-11-21 11-58-50

I was trying to establish liqo peering on the edge node (minipc) using this command:
liqoctl peer --in-band --remote-kubeconfig <KUBECONFIG_FILE> --server-service-type NodePort
but it stuck at this stage:
Waiting for Connection status to be established

Then I tried to uninstall liqo using liqoctl uninstall --purge but it returned me this message:
ERRO Pre-uninstall checks failed: you should:
disable networking for clusters:
- snowy-water

I need to remove all the clusterroles, clusterrolebindings, customresourcedefinition, services, deployments, daemonsets, pods, cronjob.batch, namespaces, mutatingwebhookconfigurations and validatingwebhookconfiguration related to liqo to be able to uninstall liqo itself.
@thisiskazem thisiskazem added the kind/bug Something isn't working label Nov 21, 2024
@claudiolor
Copy link
Contributor

Hi @thisiskazem, thanks for opening an issue.

I believe this is an expected behaviour. If you notice the error message is saying that the network needs to be disabled for peer snowy-water, so there is an active peering, even though it is broken and if you run liqoctl info you should be able to see that there is a peering with that cluster (maybe with unhealthy network).

At the moment, it is not possible to uninstall Liqo until there are active peerings, so this is expected.

In your case to be able to unistall Liqo you can launch liqoctl unpeer to remove any active peerings. Only at that point, you should be able to smoothly uninstall Liqo.

Maybe what we can do is making the error message more explicit, telling the user to use liqoctl unpeer to remove the active peerings.

@claudiolor claudiolor removed the kind/bug Something isn't working label Nov 21, 2024
@claudiolor claudiolor linked a pull request Nov 21, 2024 that will close this issue
Open
@frisso
Copy link
Member

frisso commented Nov 21, 2024

@claudiolor i agree that the message should be more clear: "disable networking for clusters" could be replaced with "unpeer following clusters..."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix] improve liqoctl uninstall error message claudiolor/liqo
3 participants
@frisso @claudiolor @thisiskazem