-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8499] a4-polls: create info box for unregistered users #2847
base: main
Are you sure you want to change the base?
Conversation
fc28107
to
1c1f572
Compare
adhocracy-plus/templates/a4polls/includes/unregistered-users-info-box.html
Outdated
Show resolved
Hide resolved
d4c8e36
to
df5bcc5
Compare
@hom3mad3 the design changed for me now, also compared to the screenshot you posted so I assume it's not intentional (or a firefox vs safari issue?) The module details are now centred in a smaller container: |
argh :/ very confused now |
looks like the content is suddenly full width instead of having the grey column left and right, maybe something got lost during the reformatting? |
df5bcc5
to
65819fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The poll header bit is fine now but sadly the grey side bits are gone:
aplus-dev (https://aplus-dev.liqd.net/buro-fur-vielfalt/projects/umfrage-3/):
and in this pr:
<div class="col-md-10 col-lg-8 offset-md-1 offset-lg-2 u-font-size-xs my-4"> | ||
<i class="fas fa-eye pe-2" aria-hidden="true"></i>{% translate 'This project is publicly visible. Invited users can actively participate.' %} | ||
<!-- these blocks are only filled when in phase view --> | ||
{% if project_action %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work as far as I know, there is no good way to check if a block
has content or not. It sadly just means that we will have to have the empty div below
@goapunk thanks. i'll probably just start this from scratch. all the context switching those last weeks means i have no idea what happened anymore 🫠 |
No worries, maybe a helpful approach especially for reviewing would be to either first do the changes without the formatting (e.g. commit with -n) or the other way round, first format the files and then do the changes in a second commit |
65819fe
to
5adc3b6
Compare
that's really helpful thanks 🫶 |
Polls UI customization: Info box for unregistered users
Desktop
Mobile