Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8499] a4-polls: create info box for unregistered users #2847

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hom3mad3
Copy link
Contributor

@hom3mad3 hom3mad3 commented Dec 3, 2024

Polls UI customization: Info box for unregistered users

  • created new snippet for the box
  • refactored the module description to remove duplicates and make it more maintainable

Desktop

Screenshot 2024-12-03 at 16-06-11 Private Project — adhocracy _liqd-orga

Mobile

@hom3mad3 hom3mad3 requested a review from goapunk December 3, 2024 15:17
@hom3mad3 hom3mad3 force-pushed the mr-2024-12-poll-info-box branch 2 times, most recently from fc28107 to 1c1f572 Compare December 3, 2024 15:34
@hom3mad3 hom3mad3 force-pushed the mr-2024-12-poll-info-box branch 4 times, most recently from d4c8e36 to df5bcc5 Compare December 5, 2024 14:13
@hom3mad3 hom3mad3 changed the title WIP [#8499] a4-polls: create info box for unregistered users [#8499] a4-polls: create info box for unregistered users Dec 5, 2024
@hom3mad3 hom3mad3 requested a review from goapunk December 5, 2024 15:01
@goapunk
Copy link
Contributor

goapunk commented Dec 5, 2024

@hom3mad3 the design changed for me now, also compared to the screenshot you posted so I assume it's not intentional (or a firefox vs safari issue?) The module details are now centred in a smaller container:
Screenshot 2024-12-05 at 16-48-00 poll — adhocracy _liqd-orga

@hom3mad3
Copy link
Contributor Author

hom3mad3 commented Dec 5, 2024

@hom3mad3 the design changed for me now, also compared to the screenshot you posted so I assume it's not intentional (or a firefox vs safari issue?) The module details are now centred in a smaller container:

argh :/ very confused now

@goapunk
Copy link
Contributor

goapunk commented Dec 9, 2024

@hom3mad3 the design changed for me now, also compared to the screenshot you posted so I assume it's not intentional (or a firefox vs safari issue?) The module details are now centred in a smaller container:

argh :/ very confused now

looks like the content is suddenly full width instead of having the grey column left and right, maybe something got lost during the reformatting?

Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poll header bit is fine now but sadly the grey side bits are gone:
aplus-dev (https://aplus-dev.liqd.net/buro-fur-vielfalt/projects/umfrage-3/):
Screenshot 2024-12-10 at 17-36-57 Poll — adhocracy _Julian-Test2244
and in this pr:
Screenshot 2024-12-10 at 17-37-17 poll — adhocracy _liqd-orga

<div class="col-md-10 col-lg-8 offset-md-1 offset-lg-2 u-font-size-xs my-4">
<i class="fas fa-eye pe-2" aria-hidden="true"></i>{% translate 'This project is publicly visible. Invited users can actively participate.' %}
<!-- these blocks are only filled when in phase view -->
{% if project_action %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work as far as I know, there is no good way to check if a block has content or not. It sadly just means that we will have to have the empty div below

@hom3mad3
Copy link
Contributor Author

hom3mad3 commented Dec 11, 2024

The poll header bit is fine now but sadly the grey side bits are gone

@goapunk thanks. i'll probably just start this from scratch. all the context switching those last weeks means i have no idea what happened anymore 🫠

@goapunk
Copy link
Contributor

goapunk commented Dec 11, 2024

The poll header bit is fine now but sadly the grey side bits are gone

@goapunk thanks. i'll probably just start this from scratch. all the context switching those last weeks means i have no idea what happened anymore 🫠

No worries, maybe a helpful approach especially for reviewing would be to either first do the changes without the formatting (e.g. commit with -n) or the other way round, first format the files and then do the changes in a second commit

@hom3mad3 hom3mad3 force-pushed the mr-2024-12-poll-info-box branch from 65819fe to 5adc3b6 Compare December 11, 2024 15:29
@hom3mad3 hom3mad3 requested a review from goapunk December 11, 2024 15:45
@hom3mad3
Copy link
Contributor Author

No worries, maybe a helpful approach especially for reviewing would be to either first do the changes without the formatting (e.g. commit with -n) or the other way round, first format the files and then do the changes in a second commit

that's really helpful thanks 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants