Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: Jd 2023 04 fontawesome 6 #2357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

wip: Jd 2023 04 fontawesome 6 #2357

wants to merge 1 commit into from

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Apr 18, 2023

No description provided.

@goapunk goapunk requested review from khamui and philli-m April 18, 2023 09:39
@goapunk goapunk added the Dev: A4 depending PR or issue dependent on A4 label Apr 18, 2023
@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited
Loading

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 12.02% 84/699
🔴 Branches 13.69% 49/358
🔴 Functions 9.62% 25/260
🔴 Lines 23.35% 527/2257

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 2d53445

@philli-m philli-m self-assigned this Apr 19, 2023
philli-m
philli-m suggested changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see a4 pr oh and check upload buttons, not sure if they work

@philli-m philli-m removed their assignment Apr 19, 2023
@goapunk goapunk force-pushed the jd-2023-04-fontawesome-6 branch from 1fdee8c to 581181b Compare April 20, 2023 14:01
@goapunk goapunk requested a review from philli-m April 20, 2023 14:02
@goapunk goapunk changed the title Jd 2023 04 fontawesome 6 WIP: Jd 2023 04 fontawesome 6 Apr 20, 2023
@goapunk goapunk force-pushed the jd-2023-04-fontawesome-6 branch from 581181b to 3e921f4 Compare April 20, 2023 14:51
@goapunk
update to fontawesome v6
2d53445 
* rename icons to new v6 names
* rename fas -> fa-solid
* rename fa -> fa-solid
* rename far -> fa-regular
@goapunk goapunk force-pushed the jd-2023-04-fontawesome-6 branch from 3e921f4 to 2d53445 Compare April 20, 2023 15:21
@goapunk goapunk changed the title WIP: Jd 2023 04 fontawesome 6 Jd 2023 04 fontawesome 6 Apr 20, 2023
@goapunk
Copy link
Contributor Author

goapunk commented Apr 20, 2023

see a4 pr oh and check upload buttons, not sure if they work

renamed fa, far and fas as well and fixed the upload buttons

@goapunk goapunk changed the title Jd 2023 04 fontawesome 6 wip: Jd 2023 04 fontawesome 6 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khamui khamui Awaiting requested review from khamui

@philli-m philli-m Awaiting requested review from philli-m

Assignees
No one assigned
Labels
Dev: A4 depending PR or issue dependent on A4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goapunk @philli-m