From b92339107d5c56d2c0d0c40ad0389f1c1901458c Mon Sep 17 00:00:00 2001 From: Peter Hutterer Date: Tue, 23 Apr 2024 08:27:50 +1000 Subject: [PATCH] test: remove the requirement for a Layout file (#661) Previously we required a layout file for any tablet with pad buttons. This somewhat prevents us from adding tablet files for unknown tablets where we can get most of the information from external sources, e.g. see #659. As a result we're missing support for these tablets altogether when we could have at least partial support. Let's drop this requirement in our tests, users who want their tablet working properly can submit layout files. --- test/test-tablet-svg-validity.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/test/test-tablet-svg-validity.c b/test/test-tablet-svg-validity.c index bb3b2d09d..311257e8c 100644 --- a/test/test-tablet-svg-validity.c +++ b/test/test-tablet-svg-validity.c @@ -233,19 +233,6 @@ struct fixture { xmlNodePtr root; }; -static void -test_filename(struct fixture *f, gconstpointer data) -{ - const WacomDevice *device = data; - const char *filename; - - filename = libwacom_get_layout_filename(device); - if (libwacom_get_num_buttons(device) > 0) { - g_assert_nonnull(filename); - g_assert_cmpstr(filename, !=, ""); - } -} - static void test_svg(struct fixture *f, gconstpointer data) { @@ -368,7 +355,6 @@ static void setup_tests(WacomDevice *device) if (g_str_equal(name, "Generic")) return; - add_test(device, test_filename); if (!libwacom_get_layout_filename(device)) return;