Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linbo-Gui HDD Anzeige funktioniert nicht bei NVME-SSDs #95

Open
nomisge opened this issue Sep 9, 2024 · 8 comments
Open

Linbo-Gui HDD Anzeige funktioniert nicht bei NVME-SSDs #95

nomisge opened this issue Sep 9, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@nomisge
Copy link

nomisge commented Sep 9, 2024

Bei unseren Geräten mit NVME-SSDs zeigt linbo unten links bei HDD nicht den Speicherplatz der Betriebssystempartition an.
Statt dessen steht dort "HDD: Prints partition size.Usage:linbo_". Da kommt wohl noch was, das ist aber nicht mehr lesbar.

Der Fehler wurde wohl schon von anderen früher bemerkt, aber vermutlich nicht weiter beachtet:
https://ask.linuxmuster.net/t/lmn-7-2-testing/9732/480

@HappyBasher HappyBasher added the bug Something isn't working label Sep 12, 2024
@HappyBasher
Copy link
Member

Ok, it's a bug, nvme clients are affected.

@HappyBasher
Copy link
Member

linbo_gui invokes linbo_cmd size /dev/nvmenp. Obviously it does not recognize the nvme disk correctly. So it's an issue of linbo_gui.

@HappyBasher HappyBasher transferred this issue from linuxmuster/linuxmuster-linbo7 Sep 16, 2024
@dorianim
Copy link
Member

@HappyBasher I think, disk detection should not be handled by the gui.

Would it be possible for linbo_cmd size (without further arguments) to print the size of the correct disk?

@HappyBasher
Copy link
Member

linbo_cmd size awaits a parameter, either a disk (eg. /dev/nvme0n1) or a partition (eg. /dev/nvme0n1p3). The gui invokes linbo_cmd size two times, once to get the disk size and once to get cache partition data. The first invokation fails because the disk device parameter is wrong, the second is successful because in this case the partition parameter is correct. Therefore I assume the gui should be able to get the correct disk device.

@HappyBasher
Copy link
Member

HappyBasher commented Sep 17, 2024

On the other hand, sure I may implement a linbo_size command, which gets the disk & cache device data itself. In this case the gui may invoke linbo_size_disk and linbo_size_cache. The problem is, which disk should be used if the client owns more than one? The disk where the cache partition resides? What do you think?

@dorianim
Copy link
Member

The problem is, which disk should be used if the client owns more than one? The disk where the cache partition resides? What do you think?

Using the disk which contains the cache partition seems like a sensible approach.

@HappyBasher
Copy link
Member

@HappyBasher
Copy link
Member

With Linbo 4.3.0 you can use linbo_size_cache and linbo_size_disk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants