Pass exclude-libraries as env var to linuxdeploy plugins #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantti
force-pushed
the
dantti/pass_exclude_libraries
branch
2 times, most recently
from
08f1d1c
to
274d684
Compare
|
@TheAssassin ping? |
|
@TheAssassin friendly ping 😄 |
TheAssassin
requested changes
Nov 17, 2024
|
Thanks for the contribution and sorry for the delay. |
dantti
force-pushed
the
dantti/pass_exclude_libraries
branch
from
274d684
to
33fd6d3
Compare
Excluding libraries doesn't properly work as of now because plugins are not notified of such exclusions, by passing the env var and automatically reading it plugins just need to be recompiled.
dantti
force-pushed
the
dantti/pass_exclude_libraries
branch
from
7295404
to
67115ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excluding libraries doesn't properly work as of now because plugins are not notified of such exclusions, by passing the env var and automatically reading it plugins just need to be recompiled.
This fixes linuxdeploy/linuxdeploy-plugin-qt#153