ci: Handle reboot for transactional update systems #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spetrosi
reviewed
Aug 6, 2024
README.md
Outdated
| @@ -112,6 +112,14 @@ timesync_ntp_provider: chrony | |||
| timesync_chrony_custom_settings: | |||
| - "logdir /var/log/chrony" | |||
| - "log measurements statistics tracking" | |||
|
|
|||
| #This variable is used to handle reboots required by transactional updates. | |||
There was a problem hiding this comment.
Suggested change
| #This variable is used to handle reboots required by transactional updates. | |
| # This variable is used to handle reboots required by transactional updates. |
Missing spaces on each comment line
README.md
Outdated
| #reboot if `timesync_transactional_update_reboot_ok` is set to `true`. If set | ||
| #to `false`, the role will notify the user that a reboot is required, allowing | ||
| #for custom handling of the reboot requirement. If this variable is not set, | ||
| #the role will fail to ensure the reboot requirement is not overlooked. |
There was a problem hiding this comment.
Please mention that this variable is only applicable for transactional update systems and is ignored otherwise. Now it sounds like this variable is required in any case.
|
[citest] |
spetrosi
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: - Added a block to identify and handle reboots for transactional update systems on package changes. Update README. Rename ALP-Dolomite var file to SL-Micro as the name is no longer used.
Reason: Ensure necessary reboots are managed, as changes on transactional update systems are applied in a separate snapshot and require a reboot to take effect.
Result: Manages system reboots for transactional update systems when a package is installed.
Issue Tracker Tickets (Jira or BZ if any):na