Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider changing contructor parameters to a struct #157

Open
linki opened this issue Nov 7, 2019 · 2 comments
Open

Consider changing contructor parameters to a struct #157

linki opened this issue Nov 7, 2019 · 2 comments
Labels
enhancement

Comments

@linki
Copy link
Owner

linki commented Nov 7, 2019

The number of arguments for Chaoskube.New() has increased to a point where it becomes annoying to use.

We could switch to a struct to have order-independent arguments by Name. It would also allow us to leave out keys when we want the default value.
@pims
Copy link
Contributor

pims commented Nov 7, 2019

What are your thoughts on functional options?

@linki
Copy link
Owner Author

linki commented Nov 8, 2019

I'm not a big fan of them but I also don't have much experience with them.

From your linked article they provide exactly what I would like so I wouldn't mind giving it a try here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pims @linki