Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base Test Classes are inefficient #294

Open
jasongilanfarr opened this issue Feb 4, 2021 · 1 comment
Open

Base Test Classes are inefficient #294

jasongilanfarr opened this issue Feb 4, 2021 · 1 comment

Comments

@jasongilanfarr
Copy link

parseq-test has a base test class that creates an engine and threadpool per test class instead of one shared one overall. The former is excellent for testing parseq itself in isolation, but the latter is better for testing usages of parseq in that it doesn't create hundreds of thousands of threads.

Happy to contribute a patch too.

@BrianPin
Copy link

BrianPin commented Feb 4, 2021

@jasongilanfarr Hi Jason, that sounds making sense, I am happy to see the patch and contribution. I will be a little bit worried the existing test cases which was originally in a mutually exclusive condition and now being in a shared resource, what will happen? flaky test? We will see, but happy to see the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants