Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should deprecate(rename)Task.blocking() #289

Open
junchuanwang opened this issue Nov 17, 2020 · 2 comments
Open

Should deprecate(rename)Task.blocking() #289

junchuanwang opened this issue Nov 17, 2020 · 2 comments
Assignees
@junchuanwang

Comments

@junchuanwang
Copy link
Contributor

junchuanwang commented Nov 17, 2020 •
edited
Loading

I recommend we change Task.blocking() to Task.runInExecutor() or Task.callableInexecutor
@BrianPin
Copy link

If we change, what about the existing users that will require them to chaneg?
These functions are actually task creation, I think if we can consider:

  1. Task.createTaskInThreadPool
  2. Task.createSimpleBlockingTask

how about that

@junchuanwang junchuanwang self-assigned this Nov 18, 2020
@junchuanwang junchuanwang mentioned this issue Feb 8, 2021
Open
@junchuanwang junchuanwang changed the title Should deprecate Task.blocking() Should deprecate(rename)Task.blocking() Feb 9, 2021
@PearlPig123
Copy link

I recommend we change Task.blocking() to Task.runInExecutor() or Task.callableInexecutor

I totally agree with this to be less confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junchuanwang junchuanwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BrianPin @PearlPig123 @junchuanwang