Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react native docs #1506

Merged
merged 19 commits into from
May 4, 2023
Merged

feat: react native docs #1506

merged 19 commits into from
May 4, 2023

Conversation

vonovak
Copy link
Collaborator

@vonovak vonovak commented Mar 12, 2023

Description

React Native docs, originally authored by me ~5 years ago, updated to latest RN 🙂

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Fixes # (issue)

Checklist

  • I have read the CONTRIBUTING and CODE_OF_CONDUCT docs
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@vercel
Copy link

vercel bot commented Mar 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
js-lingui ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 8:18am

@github-actions
Copy link

github-actions bot commented Mar 12, 2023

size-limit report 📦

Path Size
./packages/core/dist/index.mjs 1.43 KB (0%)
./packages/detect-locale/dist/index.mjs 721 B (0%)
./packages/react/dist/index.mjs 1.6 KB (0%)
./packages/remote-loader/dist/index.mjs 7.24 KB (0%)

@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0723cba) 75.33% compared to head (3779dc2) 75.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1506   +/-   ##
=======================================
  Coverage   75.33%   75.33%           
=======================================
  Files          77       77           
  Lines        1995     1995           
  Branches      517      517           
=======================================
  Hits         1503     1503           
  Misses        377      377           
  Partials      115      115           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@timofei-iatsenko
Copy link
Collaborator

@vonovak if you need any help or explanation related to upcoming v4 release you can find me in discord, i usually answer in few minutes there.

@andrii-bodnar
Copy link
Contributor

@vonovak I'm just wondering if it's possible to finalize this PR in the near future?

@vonovak vonovak marked this pull request as ready for review April 30, 2023 21:21
@vonovak vonovak requested a review from andrii-bodnar April 30, 2023 21:27
Copy link
Contributor

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vonovak thank you!

@andrii-bodnar
Copy link
Contributor

@thekip please review and let's merge this

@andrii-bodnar
Copy link
Contributor

@thekip I'd like to merge this. Feel free to comment here if you have any suggestions, and let's address those suggestions in a separate PR.

@andrii-bodnar andrii-bodnar merged commit eb0ceac into lingui:main May 4, 2023
@andrii-bodnar andrii-bodnar linked an issue May 4, 2023 that may be closed by this pull request
12 tasks
@vonovak vonovak deleted the feat/rn-docs branch May 4, 2023 08:43
@vonovak
Copy link
Collaborator Author

vonovak commented May 4, 2023

thanks for the review! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples upgrade React Native integration docs is extremely outdated
3 participants