Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Native integration docs is extremely outdated #1426

Closed
timofei-iatsenko opened this issue Feb 10, 2023 · 6 comments · Fixed by #1506
Closed

React Native integration docs is extremely outdated #1426

timofei-iatsenko opened this issue Feb 10, 2023 · 6 comments · Fixed by #1506

Comments

@timofei-iatsenko
Copy link
Collaborator

https://lingui.dev/tutorials/react-native

It's mentioned concepts from v2 version, such as:

i18n._(t`mark messages as read`)

This would not work in v3 because it will return a translated string for i18n._ instead of string id.

Also this:

        <I18n>
          {({ i18n }) => (
            <Button onPress={markAsRead} title={i18n._(t`mark messages as read`)} />
          )}
        </I18n>

There is no component with i18n name in the library on the current day.

Also example mentioned here:

If you're looking for a working solution, check out the demo on Expo. The source code is available here.

Is also outdated and repo is archived.

PS
I don't have experience with React Native at all.

@andrii-bodnar
Copy link
Contributor

@vonovak I see you have contributed to the React Native article before, maybe you would be interested in actualizing the current RN docs? 🙂

@vonovak
Copy link
Collaborator

vonovak commented Feb 13, 2023

hello @andrii-bodnar
yes, happy to do that! Also happy to see that the project appears to be in active development again.

If I have questions, what's the best time to reach you or another maintainer to get a timely response?
Thank you 🙂

@andrii-bodnar
Copy link
Contributor

Hello @vonovak, awesome, sounds great, thank you! 🚀

There are no strict time boundaries but probably the best time would be 9:00-18:00 CET, but feel free to ask questions anytime

You can also use the Lingui Discord server for more convenient communication

@vonovak
Copy link
Collaborator

vonovak commented Feb 13, 2023

@andrii-bodnar thanks, sorry I didn't mean to ask what the best time is, but what the best way to reach you is (in case you have GH notifications silenced or so) 😄

Okay, I'll use discord.

@andrii-bodnar
Copy link
Contributor

@vonovak for me both Discord and GitHub would be ok, my GH notifications aren't muted 😄

@andrii-bodnar
Copy link
Contributor

#442 - this issue still has a lot of traffic according to the repo insights. I think it should be taken into account while actualizing the RN article

@andrii-bodnar andrii-bodnar linked a pull request Mar 13, 2023 that will close this issue
7 tasks
@andrii-bodnar andrii-bodnar added this to the v4 milestone Mar 14, 2023
@andrii-bodnar andrii-bodnar removed this from the v4 milestone Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants