Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Repeating chunks of 3 to 5 missed frames about twice a second in with_winit following #752 #767

Closed
xorgy opened this issue Dec 13, 2024 · 2 comments · Fixed by #768
Labels
bug Something isn't working

Comments

@xorgy
Copy link
Member

xorgy commented Dec 13, 2024

Something in #752 (bisected) is causing the with_winit example to miss groups of 3 to 5 frames at a regular interval now.

I am running it on Mesa 24.3 RADV, on a Radeon VII. This seems to be a present issue maybe so I suspect others may also be affected. The issue is present on both X11 and Wayland, though on Wayland it has some additional effect on present.

@xorgy xorgy added the bug Something isn't working label Dec 13, 2024
@DJMcNab
Copy link
Member

DJMcNab commented Dec 13, 2024

This is due to the notify-debouncer-mini update - we seem to be getting spurious rebuilds of the render context. Looking into it now.

DJMcNab added a commit to DJMcNab/vello that referenced this issue Dec 13, 2024
It's unclear why notify-debouncer-mini ever worked for us

Fixes linebender#767
@DJMcNab
Copy link
Member

DJMcNab commented Dec 13, 2024

What seems to be happening is that when we read the shaders, that counts as a read of the file, and so triggers notify. What I don't understand is:

  1. Why this didn't happen before
  2. How notify-debouncer-mini can ever be useful. Surely you want to action the report, but if it reports the things you did in response that's useless? There's no way to reliably detect that case without a risk of false positives.

github-merge-queue bot pushed a commit that referenced this issue Dec 16, 2024
It's unclear why notify-debouncer-mini ever worked for us

Fixes #767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants