chore: update deps (vello, thiserror) #44
Conversation
| @@ -68,6 +77,8 @@ This release has an [MSRV][] of 1.75. | |||
| [#42]: https://github.com/linebender/velato/pull/42 | |||
|
|
|||
| [Unreleased]: https://github.com/linebender/velato/compare/v0.3.0...HEAD | |||
| [0.4.0]: https://github.com/linebender/velato/compare/v0.3.1...v0.4.0 | |||
| [0.3.1]: https://github.com/linebender/velato/compare/v0.3.0...v0.3.1 | |||
There was a problem hiding this comment.
I realize I forgot this link on the last release, so I'm including it here.
There was a problem hiding this comment.
That's why you should do a release as a separate PR and let someone else review it. Might've caught it.
| #[cfg(not(target_arch = "wasm32"))] | ||
| { | ||
| scene_complexity = vello::block_on_wgpu( | ||
| scene_complexity = vello::util::block_on_wgpu( |
There was a problem hiding this comment.
I'd suggest just removing the async pipeline support entirely.
There was a problem hiding this comment.
Would there be a better approach to take entirely?
The examples are copied from vello, but done so a while back. They don't have parity either, some changes were made to play lottie files obviously.
Would it be better to just remove all examples and just have a very simple wasm/native example without all the diagnostics and head scratching?
There was a problem hiding this comment.
If so, I'd be fine pushing this through and then making a follow up PR to gut the examples with a simpler one.
There was a problem hiding this comment.
Removing that pipeline doesn't matter that much in the grand scheme of things - this example is more of a demo than an actionable example.
| #[cfg(not(target_arch = "wasm32"))] | ||
| { | ||
| scene_complexity = vello::block_on_wgpu( | ||
| scene_complexity = vello::util::block_on_wgpu( |
There was a problem hiding this comment.
Removing that pipeline doesn't matter that much in the grand scheme of things - this example is more of a demo than an actionable example.
New version
0.4.0: