Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set rust-version for workspace members #842

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

sorairolake
Copy link
Contributor

The edition of all crates in this repository are Rust 2021 (requires Rust 1.56.0 or later). So we can set the rust-version field for the Cargo.toml file. This makes it easier to check the crate's MSRV.

I didn't feel the need to set this field for crates which aren't published on crates.io, so I didn't set the field for codegen and explorer-thumbnailer crates.

@DJMcNab
Copy link
Member

DJMcNab commented Nov 8, 2024

Welcome @sorairolake!

This PR has arrived at an interesting time for the project, as we're going through a relicensing. To be able to accept this contribution, we're going to need you to agree to that - see #838

One other note, the badge in the README lists the MSRV as 1.67.1. I'd probably set the MSRV to that to start with.

Thank you

@sorairolake
Copy link
Contributor Author

#838 (comment)

@sorairolake
Copy link
Contributor Author

@DJMcNab The MSRV of usvg is Rust 1.65.0 (checked with cargo-msrv), should this also be changed to Rust 1.67.1?

@DJMcNab
Copy link
Member

DJMcNab commented Nov 8, 2024

When we move to Linebender CI (see linebender/rfcs#5), we will probably want to have a unified MSRV. But since this isn't being checked, just specifying the actual reality is fine.

Thank you!

@DJMcNab DJMcNab merged commit 640bd94 into linebender:main Nov 8, 2024
3 checks passed
@sorairolake sorairolake deleted the set-rust-version branch November 8, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants