Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We received a report that thrift modules do not support java 9 modules.
When checking the specification, it seems like a identifier needs to start with a JavaLetter.
ref: https://docs.oracle.com/javase/specs/jls/se16/html/jls-7.html#jls-7.4
Unfortunately, our thrift modules contain a dot followed by a digit, which isn't a JavaLetter.
i.e.
thrift0.9
where 9 isn't a digit.I propose that for thrift modules, the last dot is omitted to avoid this issue.
i.e.
thrift0.9
->thrift09
Modifications:
automaticModuleNameOverride
so that the override configuration can live inside each moduleautomaticModuleName
is now null if not configured, or a provider if configured. This change is necessary so that the actual value ofautomaticModuleName
is not determined at configuration time, giving each module a chance to configure its ownext
property.Automatic-Module-Name
at execution time as opposed to configuration time. This is also necessary so that each module can configure its ownext
property prior to setting the name.automaticModuleNameOverride
Result: