New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force code to use single set of units #117

Open

OliviaLynn opened this issue Sep 18, 2024 · 0 comments

Member

OliviaLynn commented Sep 18, 2024

Meeting notes from Sept 10:

Want to use a single set of units and have the users convert.
- nanoJansky - DP0.2 schema, On the Choice of LSST Flux Units
- angstroms
Need to enforce this. (Might not be possible with JAX).
Document very very well.
Could look at the other codes that do parts of the functionality.
Should have conversion functions to go back and forth between TDAstro units and what is stored in the Rubin tables.

This has to be more general if we decide to include units. Also wave_units may be better here.

Originally posted by @mi-dai in #91 (comment)

I think we've decided to not do conversions at this stage. The problem is the LSST filters online are in "nm", so we would have to do the conversion offline instead of downloading it directly

Originally posted by @mi-dai in #111 (comment)

The text was updated successfully, but these errors were encountered:

OliviaLynn mentioned this issue

Passband/PassbandGroup new interface #111

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment