Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add from_legacy_dataframe calls #438

Merged
merged 3 commits into from
Apr 26, 2024
Merged

add from_legacy_dataframe calls #438

merged 3 commits into from
Apr 26, 2024

Conversation

dougbrn
Copy link
Collaborator

@dougbrn dougbrn commented Apr 26, 2024

Resolves #437

@dougbrn dougbrn requested a review from wilsonbb April 26, 2024 20:32
Copy link

github-actions bot commented Apr 26, 2024

Before [6c8f1b4] After [7889e1c] Ratio Benchmark (Parameter)
32.8±0.2ms 32.7±0.08ms 1 benchmarks.time_prune_sync_workflow
32.6±0.3ms 32.0±0.3ms 0.98 benchmarks.time_batch

Click here to view all benchmarks.

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.82%. Comparing base (6c8f1b4) to head (3e05011).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #438   +/-   ##
=======================================
  Coverage   95.82%   95.82%           
=======================================
  Files          25       25           
  Lines        1771     1772    +1     
=======================================
+ Hits         1697     1698    +1     
  Misses         74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dougbrn dougbrn marked this pull request as ready for review April 26, 2024 20:43
Copy link
Collaborator

@wilsonbb wilsonbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, noting that test_batch_by_band failures pre-existed to this PR and are tracked here #434

@dougbrn dougbrn merged commit 40236a3 into main Apr 26, 2024
11 of 12 checks passed
@dougbrn dougbrn deleted the fix_lsdb_compat branch April 26, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LSDB v0.2.1 Compatibility
2 participants