Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnsembleFrame Refactor Milestone 3: The ObjectFrame and SourceFrame #194

Closed
dougbrn opened this issue Aug 11, 2023 · 0 comments · Fixed by #222, #237 or #308
Closed

EnsembleFrame Refactor Milestone 3: The ObjectFrame and SourceFrame #194

dougbrn opened this issue Aug 11, 2023 · 0 comments · Fixed by #222, #237 or #308
Assignees
Labels
enhancement New feature or request

Comments

@dougbrn
Copy link
Collaborator

dougbrn commented Aug 11, 2023

#191 Milestone 3 focuses on the creation of the ObjectFrame and SourceFrame subclasses. Both classes inherit from the EnsembleFrame class, but enforce specific formatting requirements as currently required by the object and source tables. These requirements are:

  • Enforcement of a Object ID as the index for both
  • Column Mapping of critical columns
    • SourceFrame: [id, time, flux, error, band, provenance (optional)]
    • ObjectFrame: [id, nobs_total, nobs_{bands}]

Currently, the tape.utils.ColumnMapper class does this mapping using a single set of columns that are not divided between object and source. One aspect of this milestone may be to adjust how the ColumnMapper approaches the ObjectFrame and SourceFrame, so that critical columns are better tied to each specific frame.

@dougbrn dougbrn added the enhancement New feature or request label Aug 11, 2023
@dougbrn dougbrn changed the title EnsembleFrame Milestone 3: The ObjectFrame and SourceFrame EnsembleFrame Refactor Milestone 3: The ObjectFrame and SourceFrame Aug 11, 2023
@wilsonbb wilsonbb linked a pull request Sep 5, 2023 that will close this issue
@wilsonbb wilsonbb self-assigned this Sep 11, 2023
@wilsonbb wilsonbb linked a pull request Sep 19, 2023 that will close this issue
This was linked to pull requests Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment