Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sample files by moving them to a new GitHub repro. #49

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

CarlKCarlK
Copy link
Collaborator

This fixes the sample files (issue #48) by pointing to a new GitHub repro instead of the old AWS source.

  • The repro is at https://github.com/fastlmm/bgen-sample-files. You may want to clone it into your "limix" project instead.
  • This does not use Pooch. Instead, it uses the existing pooch-like code. Thus, avoid a dependency on Pooch.
  • However, I think some other dependency already depends on Pooch, so let me know if you'd rather use Pooch.
  • The GitHub actions fail, but not because of this change -- the original code fails, too.
  • (I accidently committed this to main for a few minutes. But I reverted and everything should is now fine.)

-- Carl

horta added a commit to limix/cbgen that referenced this pull request Nov 9, 2023
@horta horta merged commit 0652c08 into main Oct 28, 2024
0 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants