Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TAS-226] ⬆️ Bump react-native to 0.70.13 #391

Draft
wants to merge 6 commits into
base: feature/react-native
Choose a base branch
from
Draft

[TAS-226] ⬆️ Bump react-native to 0.70.13 #391

wants to merge 6 commits into from

Conversation

williamchong
Copy link
Member

@williamchong williamchong commented Jul 12, 2023 •
edited
Loading

0.70 enables hermes js engine, which requires clean build in both android and ios

@williamchong williamchong changed the title Feature/react native 0.70 ⬆️ Bump react-native to 0.70.12 Jul 12, 2023
@williamchong williamchong changed the base branch from develop to feature/react-native July 12, 2023 10:06
@nwingt
Copy link
Member

nwingt commented Jul 19, 2023

Required 0.71?
Simulator Screenshot - iPhone SE (3rd generation) - 2023-07-19 at 17 05 44

@williamchong
Copy link
Member Author

Required 0.71? Simulator Screenshot - iPhone SE (3rd generation) - 2023-07-19 at 17 05 44

big-integer is still in package.json dependency, so it should be resolvable
Maybe just npm install went wrong?

@williamchong williamchong changed the title ⬆️ Bump react-native to 0.70.12 [TAS-226] ⬆️ Bump react-native to 0.70.12 Aug 4, 2023
@notion-workspace
Copy link

Upgrade react native to 0.70

nwingt added a commit that referenced this pull request Oct 13, 2023
@nwingt
🔀 Merge #391 into release/v0.35.0
9c6cfe8
@nwingt
Copy link
Member

nwingt commented Oct 13, 2023

Encounter this when clicking the logout button on RN 0.70
image

@williamchong williamchong changed the title [TAS-226] ⬆️ Bump react-native to 0.70.12 [TAS-226] ⬆️ Bump react-native to 0.70.13 Oct 16, 2023
@williamchong williamchong force-pushed the feature/react-native-0.70 branch from 155c78b to 4097717 Compare November 13, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamchong @nwingt