Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend-Test-Setup is broken #501

Closed
RetGal opened this issue Aug 19, 2019 · 2 comments · Fixed by #509
Closed

Frontend-Test-Setup is broken #501

RetGal opened this issue Aug 19, 2019 · 2 comments · Fixed by #509
Assignees
@mburri
Milestone
Version 1.17.16

Comments

@RetGal
Copy link
Contributor

RetGal commented Aug 19, 2019

Frontend-Test-Setup is broken
Might be caused by Karma upgrade 1.7.1 to 4.1.0
@mburri
Copy link
Member

mburri commented Aug 20, 2019 •
edited
Loading

reverting to karma 1.7.1 (and other karma related dependecies) does not help.
Tests are failing with
$ is not defined

looks as if the root cause was the jquery update...
tests are running in commit 76e6cad

@mburri
Copy link
Member

mburri commented Aug 21, 2019

it was not the update itself but the changes in order to restore the datepicker functionality 7bd1ee7

Works in the Browser since jQuery usually gets loaded on the application entry point - but when running the tests in isolation....

@yvespp yvespp added this to the Version 1.17.16 milestone Sep 2, 2019
@mburri mburri self-assigned this Sep 3, 2019
@mburri mburri mentioned this issue Sep 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mburri mburri

Labels
None yet
Projects
None yet
Milestone
Version 1.17.16
Development

Successfully merging a pull request may close this issue.

Fix issue 38 broken frontend testsetup liimaorg/liima
3 participants
@mburri @yvespp @RetGal