Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal body is separated from the footer #28

Open
tombertrand opened this issue Oct 18, 2019 · 2 comments
Open

Modal body is separated from the footer #28

tombertrand opened this issue Oct 18, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@tombertrand
Copy link

tombertrand commented Oct 18, 2019

Description

When the body exceeds the screen height, a space is created with the footer

Good / Normal
image

Bug
image

Expected behavior

The footer should be attached to the body at time and the body should be scrollable if it exceeds the window height

Steps to reproduce the problem

https://codesandbox.io/s/optimistic-cookies-06yx7

add a few elements to the modal body if you can't see it

Specifications

  • Affected component(s): Modal
  • Versions: Latest
@glambert glambert added the bug Something isn't working label Oct 24, 2019
@glambert
Copy link
Collaborator

Definitely a bug, thanks for the report @tombertrand 👍

@xdrdak
Copy link
Contributor

xdrdak commented Nov 5, 2019

This can actually be fixed by using the scroll prop on the ModalBody.

Which sorta makes me wonder why we need to add the scroll prop in the first place if the behaviour we want is to always have the overflow automatically active when the size of the modal viewport no longer fits.

In any case, try adding the scroll prop to ModalBody, if it works, I'll close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants