Flame base components mobile-friendliness #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for lightspeed-flame ready! Built with commit 0db09e4 |
glambert
reviewed
Oct 16, 2019
* Add responsive styled props and adjust based on specs * Update CHANGELOG.md * Slightly better lineheight * More fun typescript clashing * Update snapshots * Update CHANGELOG.md * Update CHANGELOG.md * Added percy configs as helpers * Fix description spacing for Checkbox/Radio * Update snapshots for Checkbox/Radio
* Make Alert and Icon mobile friendlier
* Make switch more mobile friendly * Add percy breakpoints to story snapshots
* Make BaseInput responsive. Leverage css prop * Remove usage of cssGet in favour of core/css * Fix core/css function. Convert input wrapper to use css props * Leverage css props for input * Replace setBaseInputSize * Add percy breakpoint snapshots * Resize label component for mobile
* Make select more mobile friendly * Add Percy breakpoints to select story * Fix border radii for select * Update select snapshot
glambert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More info coming soon.
Closes #25
Epic pull requests
How to test?
yarn devChecklist