Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Sass from Storybook #1

Open
xdrdak opened this issue Sep 12, 2019 · 3 comments
Open

Remove Sass from Storybook #1

xdrdak opened this issue Sep 12, 2019 · 3 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@xdrdak
Copy link
Contributor

xdrdak commented Sep 12, 2019

Description

Remove all Sass references and usage of it from our stories.

Since we want to promote the usage of emotion, it might make more sense to build custom components using emotion + our theme values than pulling stuff from our legacy generated Sass values.

This will also enable us to remove some rather pointless plugins to bundle css and sass into the final storybook build.

@xdrdak xdrdak added the good first issue Good for newcomers label Sep 12, 2019
@xdrdak xdrdak self-assigned this Sep 12, 2019
@glambert glambert changed the title Remove SASS from storybook Remove Sass from storybook Sep 13, 2019
@glambert glambert changed the title Remove Sass from storybook Remove Sass from Storybook Sep 13, 2019
@glambert
Copy link
Collaborator

Partially closed by #7, correct?

@alexismo
Copy link
Contributor

alexismo commented Jan 9, 2020

flame/stories/styles/stories.scss still uses a bunch of Sass

@glambert
Copy link
Collaborator

flame/stories/styles/stories.scss still uses a bunch of Sass

Yup, "partially" is the keyword 😄This still needs to be done, wanna pick up @alexismo? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants