[bug]: unclean shutdown in funding causes ChannelFinalized to be missed

[Crypt-iQ]

• If a node is the funder in a funding flow and receives FundingSigned, funderProcessFundingSigned will be called: https://github.com/lightningnetwork/lnd/blob/e9dd01b60dd22a3e0181a1f4e924cb3d438fb518/funding/manager.go#L2683C19-L2683C45
• If the node has an unclean shutdown of lnd immediately after a successful call to CompleteReservation here (

  lnd/funding/manager.go

  Lines 2778 to 2780 in e9dd01b

  	completeChan, err := resCtx.reservation.CompleteReservation(
  	nil, commitSig,
  	)

  ), then potentially some of the below calls won't ever execute if they're not also handled in the restart case. A similar thing happens in the CompleteReservationSingle case. The only call I found that was missed on restart was the ChannelFinalized call to the AuxController:

  lnd/funding/manager.go

  Lines 2835 to 2840 in e9dd01b

  	err = fn.MapOptionZ(
  	f.cfg.AuxFundingController,
  	func(controller AuxFundingController) error {
  	return controller.ChannelFinalized(cid.tempChanID)
  	},
  	)

[dstadulis]

unclean shutdown

clarifying:
unclean shutdown = premature shutdown? e.g. a call doesn't sufficiently block shutdown
or
unclean shutdown = mutated state is written

[Crypt-iQ]

@dstadulis The process itself uncleanly shuts down (e.g. killed by oom-killer or something)