config: fix profile port arg parsing #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we fix a subtle bug in the parsing of the yaml config. With the way the library works, the attribute name needs to match the config attribute name. Otherwise, parsing just doesn't work.
ellemouton
approved these changes
Nov 20, 2023
| // ProfilePort is the port on which the pprof profile will be served. | ||
| ProfilePort uint16 `long:"profile" description:"Enable HTTP profiling on given port -- NOTE port must be between 1024 and 65535"` | ||
| // Profile is the port on which the pprof profile will be served. | ||
| Profile uint16 `long:"profile" description:"Enable HTTP profiling on given port -- NOTE port must be between 1024 and 65535"` |
There was a problem hiding this comment.
Yeah a weird quirk with the YAML parser, I think we might've ran into this w/ the sqlite stuff too, but alas the wisdom was forgotten....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we fix a subtle bug in the parsing of the yaml config. With the way the library works, the attribute name needs to match the config attribute name. Otherwise, parsing just doesn't work.