Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prom: Add base and proportional fee to the channel metric. #460

Closed
wants to merge 1 commit into from
Closed

prom: Add base and proportional fee to the channel metric. #460

wants to merge 1 commit into from

Conversation

bleetube
Copy link

Closes #398

This PR adds the requested channel metrics:

# HELP lightning_channel_fee_base_msat How many msats do we charge as a base fee for routing?
# TYPE lightning_channel_fee_base_msat gauge
lightning_channel_fee_base_msat{alias="deezy.io ⚡✨",id="024bfaf0cabe7f874fd33ebf7c6f4e5385971fc504ef3f492432e9e3ec77e1b5cf",scid="792604x1216x0"} 1000.0
# HELP lightning_channel_fee_proportional_millionths How many millionths of the forwarded amount do we charge for routing?
# TYPE lightning_channel_fee_proportional_millionths gauge
lightning_channel_fee_proportional_millionths{alias="deezy.io ⚡✨",id="024bfaf0cabe7f874fd33ebf7c6f4e5385971fc504ef3f492432e9e3ec77e1b5cf",scid="792604x1216x0"} 10.0
# HELP lightning_channel_in_payments_offered How many incoming payments did we try to forward?

Not actually sure if this change is actually warranted or not, but it seems reasonable to me.

@bleetube bleetube changed the title Add base and proportional fee to the channel metric. prom: Add base and proportional fee to the channel metric. Jun 23, 2023
@cdecker cdecker force-pushed the prom_add_channel_metrics branch from f2c6c88 to 38cef3d Compare July 20, 2023 12:48
@cdecker
Copy link
Contributor

cdecker commented Jul 20, 2023

I took the liberty of adapting the two new metrics after merging #451.

@bleetube bleetube closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prometheus: Add fees to channel metric
2 participants
@bleetube @cdecker