Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend values should not overlap with charts #12801

Closed
jpetey75 opened this issue Dec 9, 2024 · 2 comments · Fixed by #12923
Closed

Legend values should not overlap with charts #12801

jpetey75 opened this issue Dec 9, 2024 · 2 comments · Fixed by #12923
Assignees
Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience 💜 customer support Tickets created while on support week

Comments

@jpetey75
Copy link
Contributor

jpetey75 commented Dec 9, 2024

Description

Series values that have longer text fields should be text wrapped or maybe cut off in legends rather than overlapping with the chart.

Steps to Reproduce the Bug or Issue

Turn on a vertically stacked Legend in a Pie chart that has long values, or other chart types too (bar chart, etc.)

CleanShot 2024-12-09 at 16 09 51@2x

version

No response

Cloud or self-hosting

None

@jpetey75 jpetey75 added the 🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience label Dec 9, 2024
@lightdash-bot
Copy link
Collaborator

@hamzahc1 hamzahc1 added the 💜 customer support Tickets created while on support week label Dec 11, 2024
@hamzahc1 hamzahc1 added this to the 💜 Customer Support milestone Dec 11, 2024
@ZeRego ZeRego self-assigned this Dec 12, 2024
@ZeRego ZeRego moved this from 📝 To-Do to 🏗 In progress in Selected for Development Dec 12, 2024
@ZeRego
Copy link
Contributor

ZeRego commented Dec 13, 2024

@jpetey75 Echarts doesn't have a configuration to avoid this neither provide the information for us to calculate it programmatically.

Echarts ticket: apache/echarts#14252
^ Note that we have left comments about this in 2022

The chart can also be adjusted to any ratio, so what should happen to the legend?

Image

As a compromise, we can limit the labels to 50 characters. Doesn't solve all the cases based on square ratios but will solve the problem where the legend covers the entire chart.

@ZeRego ZeRego moved this from 🏗 In progress to ⛔️ Blocked in Selected for Development Dec 13, 2024
@owlas owlas moved this from ⛔️ Blocked to 📝 To-Do in Selected for Development Dec 16, 2024
@ZeRego ZeRego moved this from 📝 To-Do to 🏗 In progress in Selected for Development Dec 16, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Selected for Development Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working as expected. This can be an error or an unexpected user experience 💜 customer support Tickets created while on support week
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants