Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache invalidated might fail on Mac M1/M2 #640

Open
pgarba opened this issue Nov 29, 2022 · 1 comment
Open

Cache invalidated might fail on Mac M1/M2 #640

pgarba opened this issue Nov 29, 2022 · 1 comment

Comments

@pgarba
Copy link
Contributor

pgarba commented Nov 29, 2022

The cache invalidation might fail if a new function is allocated at the same address as the cached one.
This happens to me on the M2 after I delete a function and then allocate a new one which leads to return a nullptr for cached values and results in a crash.

if (func != impl->last_func) {

@pgoodman
Copy link
Collaborator

Perhaps the cache invalidation should hold a weak value handle on the llvm function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants