Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebuilt docker images are missing #339

Open
TBX3D opened this issue Oct 25, 2024 · 13 comments
Open

Prebuilt docker images are missing #339

TBX3D opened this issue Oct 25, 2024 · 13 comments

Comments

@TBX3D
Copy link

TBX3D commented Oct 25, 2024

I've been struggling to build rellic, so I tried to install one of the docker images, but the page returns a 404 error. Please review.

@frabert
Copy link
Collaborator

frabert commented Oct 30, 2024

I'm not in charge of the Docker images so right now I can't help with that, but could you elaborate on the issues you've been having building rellic?

@TBX3D
Copy link
Author

TBX3D commented Oct 30, 2024

I've kind of came to the conclusion that you can't build rellic or cxx-commons in debian, so I'm going to try it in ubuntu (I think that's what it is for the project?)

@frabert
Copy link
Collaborator

frabert commented Oct 31, 2024

I believe it's more of a "it has never been tried" more than a "it can't be done", but your point stands.

In any case, I would probably be able to provide more guidance if you share which steps are failing, and how :)

@TBX3D
Copy link
Author

TBX3D commented Nov 5, 2024

that sounds good, I'll find some time I'm free and we could potentially figure it out.

@TBX3D
Copy link
Author

TBX3D commented Nov 10, 2024

hello, are you still interested in checking this out?

@frabert
Copy link
Collaborator

frabert commented Nov 11, 2024

Yes, feel free to share any details on what you're encountering and I can try to help with that

@TBX3D
Copy link
Author

TBX3D commented Nov 19, 2024

an error occurs when building rellic in debian (WSL).
all dependencies seem to be up to date and were installed through the apt package manager

FAILED: lib/CMakeFiles/rellic.dir/AST/IRToASTVisitor.cpp.o
/usr/bin/c++ -DGFLAGS_IS_A_DLL=0 -I/home/owo/rellic/include -isystem /home/owo/lifting-bits-downloads/vcpkg_ubuntu-22.04_llvm-16_amd64/installed/x64-linux-rel/include -O2 -g -DNDEBUG -fvisibility=hidden -fvisibility-inlines-hidden -Werror -pedantic -Wno-unreachable-code-return -MD -MT lib/CMakeFiles/rellic.dir/AST/IRToASTVisitor.cpp.o -MF lib/CMakeFiles/rellic.dir/AST/IRToASTVisitor.cpp.o.d -o lib/CMakeFiles/rellic.dir/AST/IRToASTVisitor.cpp.o -c /home/owo/rellic/lib/AST/IRToASTVisitor.cpp
/home/owo/rellic/lib/AST/IRToASTVisitor.cpp: In member function ‘clang::Expr* rellic::ExprGen::visitCastInst(llvm::CastInst&)’:
/home/owo/rellic/lib/AST/IRToASTVisitor.cpp:899:7: error: attributes at the beginning of statement are ignored [-Werror=attributes]
  899 |       [[clang::fallthrough]];
      |       ^~~~~~~~~~~~~~~~~~~~~~
At global scope:
cc1plus: note: unrecognized command-line option ‘-Wno-unreachable-code-return’ may have been intended to silence earlier diagnostics
cc1plus: all warnings being treated as errors

@frabert
Copy link
Collaborator

frabert commented Nov 19, 2024

Can you post the output of c++ --version?

@pgoodman
Copy link
Collaborator

This could probably be changed to [[fallthrough]]; now.

@frabert
Copy link
Collaborator

frabert commented Nov 19, 2024

True! @TBX3D can you try mass-substituting every [[clang::fallthrough]]; to [[fallthrough]];, then recompiling?

@TBX3D
Copy link
Author

TBX3D commented Nov 20, 2024

and also c++ --version:

$ c++ --version
c++ (Debian 13.3.0-3) 13.3.0
Copyright (C) 2023 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.  There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

@TBX3D
Copy link
Author

TBX3D commented Nov 20, 2024

GOOD NEWS: by changing [[clang::fallthrough]]; to [[fallthrough]]; in line 899 of IRToASTVisitor.h, rellic is successfully built. I will test it and if I find any further issues I will share them here, but it built just fine.

@TBX3D
Copy link
Author

TBX3D commented Nov 20, 2024

Well, it seems to be working with the example, so thank you guys for the help! happy to have rellic in my toolkit
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants