Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Bootstrap Improvements Optional #7

Open
KazW opened this issue Dec 11, 2016 · 0 comments
Open

Make Bootstrap Improvements Optional #7

KazW opened this issue Dec 11, 2016 · 0 comments

Comments

@KazW
Copy link

KazW commented Dec 11, 2016

Hi, thanks for creating this library, it makes adding bootstrap to Ember really easy!

That said, I believe the vendor/ui-bootstrap/ui-bootstrap-improvements.css file is best left as an opt-in, instead of being default. It breaks the look of the fixed navbar, putting a 1rem gap between it and the top of the viewport. Right now my solution has been to remove the assets/vendor.css line from app/index.html. This solution is less than ideal since I may need that file in the future, and would have to undo the improvements explicitly in my app's CSS.

I think that for those wanting a stock bootstrap experience, it should be more easily attainable.

Let me know if you agree, if so, I'm happy to do the work and open a PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant