You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, thanks for creating this library, it makes adding bootstrap to Ember really easy!
That said, I believe the vendor/ui-bootstrap/ui-bootstrap-improvements.css file is best left as an opt-in, instead of being default. It breaks the look of the fixed navbar, putting a 1rem gap between it and the top of the viewport. Right now my solution has been to remove the assets/vendor.css line from app/index.html. This solution is less than ideal since I may need that file in the future, and would have to undo the improvements explicitly in my app's CSS.
I think that for those wanting a stock bootstrap experience, it should be more easily attainable.
Let me know if you agree, if so, I'm happy to do the work and open a PR.
Thanks!
The text was updated successfully, but these errors were encountered:
Hi, thanks for creating this library, it makes adding bootstrap to Ember really easy!
That said, I believe the
vendor/ui-bootstrap/ui-bootstrap-improvements.css
file is best left as an opt-in, instead of being default. It breaks the look of the fixed navbar, putting a 1rem gap between it and the top of the viewport. Right now my solution has been to remove theassets/vendor.css
line fromapp/index.html
. This solution is less than ideal since I may need that file in the future, and would have to undo the improvements explicitly in my app's CSS.I think that for those wanting a stock bootstrap experience, it should be more easily attainable.
Let me know if you agree, if so, I'm happy to do the work and open a PR.
Thanks!
The text was updated successfully, but these errors were encountered: