Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all modes failed on certain bitstream #16

Closed
rhwu opened this issue Feb 22, 2020 · 2 comments
Closed

all modes failed on certain bitstream #16

rhwu opened this issue Feb 22, 2020 · 2 comments

Comments

@rhwu
Copy link

rhwu commented Feb 22, 2020

Attached test2.264 (640x480) failed on all the 3 modes. But I'm able to do muxing with this bitstream using ffmpeg:
$ ffmpeg -framerate 30 -i test2.264 -c copy test2.mp4

test2.264.zip

@lieff
Copy link
Owner

lieff commented Feb 22, 2020

This stream is progressive high profile, needs to be supported in mp4_h26x_write_nal helper. Will do this at some point. Fragmentation mode + slices also currently not supported.

minimp4 still can be used in such cases, just other demuxer should be used instead of mp4_h26x_write_nal which correctly aggregates one h264 frame into sample and pass it directly to MP4E_put_sample.

@lieff
Copy link
Owner

lieff commented Feb 22, 2020

Turns out it's trivial to fix. Problem was not in progressive encoding as I think at first, but in access unit delimiter NALu`s which was not handled. This 8bbd1ca fixes default and sequential modes, for fragmentation mode there same issue as #15 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants