Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference with gitlab.com/joshua.software.dev/LMeter ? #64

Open
chennin opened this issue Jul 18, 2024 · 3 comments
Open

Difference with gitlab.com/joshua.software.dev/LMeter ? #64

chennin opened this issue Jul 18, 2024 · 3 comments

Comments

@chennin
Copy link

chennin commented Jul 18, 2024

Hello! I'm confused about this project and https://gitlab.com/joshua.software.dev/LMeter - they have the same name, the same first sentence of the README, and "Lichie" is credited on the gitlab repo.

I was using the gitlab with Dalamud, but it hasn't been updated for DT yet, and this project seems to be the same thing, but not a direct fork (as far as I looked back at commits) but more active? Can you please clarify?

(Also, some screenshots in the README would be highly appreciated to clarify what it does/can look like)

@bioxz
Copy link

bioxz commented Jul 19, 2024

Looking at the commit history it looks like the version of joshua.software.dev was forked from the commit 964d200 over a year ago and was developed independently since then. I guess changes where inspired in both directions? The fork implemented Linux support quite early for example, which maybe was the original reason for the fork, but this one followed since. Could also be completely wrong, but that is how it looks to me.

I guess the biggest difference for the user is/was cactbot support in the fork. Clarification would be helpful in both projects. The fork has a way better README.md, but does not mentioned the original project, while this project lacks any information about the features in the README.md. At also seems that this project switched from GPL to MIT, while the fork is still under GPL (which is quite interesting, as such a change requires agreement of every single contributor to the licensed work).

@lichie567
Copy link
Owner

Joshua forked the project during a time when I wasn't playing the game and was not doing any feature development. Actually, my entire reason for making LMeter in the first place was for linux support. My version works perfectly fine on Linux. I'm not exactly sure what his version does that supposedly improves linux support, but I play the game almost exclusively on Linux myself and have no issues. I think some of his Linux features may be more specifically for the steam deck, but I do not own one so I cannot confirm if there are any issues specifically on the steam deck.

I actually switched from GPL to MIT when Joshua approached me at some point regarding licensing. I hadn't realized that github had generated a GPL3 license for the project automatically, and had never intended to use it. He may not be aware that I changed the license, which is why his repo still has GPL3.

@bioxz
Copy link

bioxz commented Jul 21, 2024

Thank you for the clarification!

Actually, my entire reason for making LMeter in the first place was for linux support. My version works perfectly fine on Linux. I'm not exactly sure what his version does that supposedly improves linux support, but I play the game almost exclusively on Linux myself and have no issues. I think some of his Linux features may be more specifically for the steam deck, but I do not own one so I cannot confirm if there are any issues specifically on the steam deck.

I did not try to make any accusations of having worse Linux support, sorry if it sounded that way. The commit messages of the fork made it look like some changes were required, I was still on console last year, so I have only the commit history to go by.

Will be interesting to see if the fork will become active again. Maybe it's possible to fork the Cactbot support into a standalone plugin and see if there are some LMeter improvements which would be merged back here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants