OP_INVERT was modifying bytes in place, now they are popped, modified, and pushed back onto the stack #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is where the error is being generated. Maybe we can fix lower in the stack if we think about split? Signed-off-by: Darren Kellenschwiler <[email protected]>
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
=======================================
Coverage 80.63% 80.64%
=======================================
Files 38 38
Lines 4115 4117 +2
=======================================
+ Hits 3318 3320 +2
Misses 546 546
Partials 251 251
☔ View full report in Codecov by Sentry. |
sirdeggen
changed the title
boecklim
reviewed
Aug 16, 2023
Signed-off-by: Darren Kellenschwiler <[email protected]> # Conflicts: # bscript/interpreter/engine_test.go
sirdeggen
force-pushed
the
fix/op-invert-bug-fix
branch
from
351f4dc
to
07c2ab9
Compare
boecklim
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like it's only OP_INVERT which was causing this strange bug.
Scenario
PushTx methodology is used across a number of smart contracts. Optimized code uses a public key associated with the private key Bn(1). The unlocking script contains a complete preimage for the sake of forward enforcement among other things. That preimage has its nSequence inverted somewhere in the example script, but while it's inverted on the stack, the other items on the stack containing the same bytes are also inverted.
Fix
Rather than Peek, we Pop the byte array, clone it, invert the clone and push that on to the stack. It might not be as memory efficient, but it at leasts solves this bizarre problem.