Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong audio samplerate when using framerates other than 60FPS. #182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vanfanel
Copy link

@vanfanel vanfanel commented Apr 5, 2023

The engine seems to generate 44100 samples per second, which sounds good at 60FPS, but sounds at the wrong speed when settings other framerates in the the game options.
So this simply compensates the number of samples generated so it sounds good with other framerates.

@anzz1
Copy link

anzz1 commented May 14, 2023

This sounds like a frontend / audio backend issue rather than a core issue. Audio sample rate should definitely not be related to video frame rate like that. On my frontend the audio works correctly at whatever framerate, i.e. changing the frame rate does not affect the pitch / speed / rate, nor should it.

Would not merge this, as further investigation to the real cause is warranted. I would start investigating the frontend / audio backend, not change the sample rate to an arbitrary value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants