Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to visuals and controls in notification #2624

Closed
3 tasks done
GilesMunn opened this issue Jan 7, 2023 · 6 comments · Fixed by #2713
Closed
3 tasks done

Improvements to visuals and controls in notification #2624

GilesMunn opened this issue Jan 7, 2023 · 6 comments · Fixed by #2713
Labels
enhancement New feature or request

Comments

@GilesMunn
Copy link
Contributor

Describe your suggested feature

The notification for currently-playing videos is currently low-resolution, would it be possible to use the highest-quality version of the thumbnail to use as the banner so that the notification background looked less pixelated?
Screenshot_20230107-153319

It'd also be nice if we could have Fastforward/Rewind buttons added to the notification controls, such as can be found in the VLC app here:
Screenshot_20230107-153229

They can also work alongside the Back/Next buttons if you're currently watching a playlist (we currently only have the Back button), as can be seen here:
Screenshot_20230107-153243

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@Bnyro
Copy link
Member

Bnyro commented Jan 9, 2023

Before TeamNewPipe/NewPipeExtractor#889 gets merged, we can't get a better resolution of the thumbnail without risks unfortunately. We could try something like TeamNewPipe/NewPipeExtractor#268 (comment), but that could result in no thumbnail being found in the end.

@GilesMunn
Copy link
Contributor Author

Could we perhaps try the mentioned method and have the current system as a fallback if none are found?

@Bnyro
Copy link
Member

Bnyro commented Jan 9, 2023

We could try to do so, afaik Coil supports fallback sources by default so should be doable I guess

@Silther
Copy link
Contributor

Silther commented Jan 14, 2023

On older devices (or partly new ones, thanks samsung) the new media player is not yet supported and e.g. the cover image was once cropped to a square, which no longer works.

Screenshot_20230114_140949_LibreTube.png

@Bnyro
Copy link
Member

Bnyro commented Jan 16, 2023

Looks like we already get the best thumbnail resolution from the API, the issue seems to be androidx/media#168

@Silther
Copy link
Contributor

Silther commented Jan 16, 2023

On older devices (or partly new ones, thanks samsung) the new media player is not yet supported and e.g. the cover image was once cropped to a square, which no longer works.

What about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants