Skip to content
This repository has been archived by the owner on Jun 11, 2020. It is now read-only.

Merge websocket star and webrtc star signal server #33

Closed
JustMaier opened this issue Jun 30, 2019 · 5 comments
Closed

Merge websocket star and webrtc star signal server #33

JustMaier opened this issue Jun 30, 2019 · 5 comments

Comments

@JustMaier
Copy link
Contributor

Currently Webrtc star has a signal server bundled into the library. I purpose moving it into its own library or merging it into this library and put them behind flags. Thoughts?

@mkg20001
Copy link
Member

WebSocketStar is in the process of being deperacted due to protocol problems, such as not having any buffering mechanisms which usually caused the whole thing to blow up multiple times a day.

It would be great though, to take the code from here and use it as a base for the WebRTCStar Server

Another thing that's in progress is https://github.com/mkg20001/interface-data-exchange (currently WIP), which might completly remove the server requirement in WebRTCStar and simply re-use the existing libp2p swarm instead of adding socket.io into the mix.

@JustMaier
Copy link
Contributor Author

Interesting. Looks like there hasn't been much movement on data- exchange in the last few months, but it sounds great. Are you up for a brief call to chat about the idea a bit? I'd be willing to take a stab at pushing the protocol forward.

@mkg20001
Copy link
Member

mkg20001 commented Jul 1, 2019

Are you up for a brief call to chat about the idea a bit? I'd be willing to take a stab at pushing the protocol forward.

Do you mean zoom? Yes, but my scheudle today is pretty limited. Otherwise usually from 16:30 UTC+1
Recently I've decided to continue the protocol, working on making it use Promises. mkg20001/interface-data-exchange#1
You should be able to take most of the info out of this PR libp2p/js-libp2p-webrtc-star#148 and the linked slides https://docs.google.com/presentation/d/1yfxI_4wY-5ydFxcIr2NBsg8E0wyJJStekRfectZjcf0/edit?usp=sharing

Edit: The reason the protocol development stalled is because of some other PRs, some of which still aren't merged or finished. libp2p/js-libp2p-webrtc-star#148 (comment)

Edit 2: We could move this forward as a joint endeavor ^^ I will have more time again for open source projects quite soon.

@JustMaier
Copy link
Contributor Author

@mkg20001 sounds good. I just got back from a trip and I should be able to jump on Zoom or Discord to chat. I'm UTC-7 atm, so any time after 16:30 UTC+1 should work for me as well.

@mkg20001
Copy link
Member

@JustMaier sent you the details via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants