Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't use invalid port 0 when NATMap fails #3058

Closed
wants to merge 1 commit into from
Closed

fix: don't use invalid port 0 when NATMap fails #3058

wants to merge 1 commit into from

Conversation

wlynxg
Copy link
Contributor

@wlynxg wlynxg commented Nov 21, 2024

fix: #3057

sukunrt
sukunrt requested changes Nov 25, 2024
View reviewed changes
Copy link
Member

@sukunrt sukunrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @wlynxg

p2p/net/nat/nat.go Outdated Show resolved Hide resolved
p2p/host/basic/basic_host.go Outdated Show resolved Hide resolved
@p-shahi
Copy link
Member

p-shahi commented Dec 2, 2024

@wlynxg thanks for the contribution - Would you like to address Sukun's feedback?

@wlynxg
Copy link
Contributor Author

wlynxg commented Dec 3, 2024 •
edited
Loading

@wlynxg thanks for the contribution - Would you like to address Sukun's feedback?

I will refer to Sukun's feedback and re-edit the code later.

@sukunrt
Copy link
Member

sukunrt commented Dec 8, 2024

Apologies for the confusion here. This specific method's code is too confusing. I think your original approach of erroring when port is 0 was correct.

closing in favour of: #3094
rest is handled by: #3075

@sukunrt sukunrt closed this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukunrt sukunrt sukunrt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NATMap mapping failed, resulting in an observed address error
3 participants
@wlynxg @p-shahi @sukunrt