Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variable-length keys #10

Open
petar opened this issue Sep 3, 2020 · 0 comments
Open

Support variable-length keys #10

petar opened this issue Sep 3, 2020 · 0 comments

Comments

@petar
Copy link
Collaborator

petar commented Sep 3, 2020

The trie can be updated to support variable length keys. Naturally, this requires updating the logic in all methods (Add, Find, Remove, etc.)

This functionality was already needed in libp2p/go-libp2p-asn-util#8, but only for Add and Find.
There, we opted to make a copy of the trie structure and update just Add and Find, due to time constraints.

We need to reconcile the two implementations and have just one (here) which supports variable-length keys on all of its methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant