Skip to content
This repository has been archived by the owner on Nov 22, 2022. It is now read-only.

Update dependencies #29

Merged
merged 2 commits into from
Apr 19, 2019
Merged

Update dependencies #29

merged 2 commits into from
Apr 19, 2019

Conversation

backkem
Copy link
Contributor

@backkem backkem commented Apr 9, 2019

This PR contains:

  • Adjustments for the pions to pion reorg.
  • Upgrade to the (now tagged) pion v2 release.
  • Separate modules files for the examples to reduce dependencies of the main library.

Resolves #10

@albrow albrow mentioned this pull request Apr 9, 2019
Closed
@backkem
Copy link
Contributor Author

backkem commented Apr 9, 2019

The CI is probably timing out due to SACK storm which is aimed to be solved by pion/sctp#32.

@albrow
Copy link
Contributor

albrow commented Apr 10, 2019 •
edited
Loading

@backkem I wonder if we can get CI to pass in the meantime by increasing the timeout or increasing the CPU/RAM resources? It would be inconvenient to stop development while waiting for pion/sctp#32 to be addressed.

@albrow albrow mentioned this pull request Apr 10, 2019
Merged
@backkem
Copy link
Contributor Author

backkem commented Apr 10, 2019

I'm not sure if we can assign more resources. It does seem like there is a travis_wait command that we could use to prolong the timeout of a command that doesn't print to sdtout for a while.

@backkem backkem mentioned this pull request Apr 16, 2019
Closed
@backkem backkem requested a review from albrow April 18, 2019 14:30
@backkem backkem merged commit b213ddc into master Apr 19, 2019
@backkem backkem deleted the dep branch April 19, 2019 07:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@albrow albrow albrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SCTP reliability
2 participants
@backkem @albrow