Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Formaldehyde devices on manual installation #28

Closed
emagnier opened this issue Jun 5, 2023 · 3 comments
Closed

Missing Formaldehyde devices on manual installation #28

emagnier opened this issue Jun 5, 2023 · 3 comments

Comments

@emagnier
Copy link

emagnier commented Jun 5, 2023

I'm doing a manual installation.

I've a Dyson Purifier Cool Formaldehyde, but I do not see any Formaldehyde devices in the dropdown. Furthermore, some devices are listed twice in the list.

FYI, Formaldehyde devices were correctly output in the previous shenxn repo.

Screenshot 2023-06-05 at 12 55 40

@dotvezz
Copy link
Member

dotvezz commented Jun 5, 2023

Hey, thanks for the issue. I'm happy to say that Purifier Cool Formaldehyde is fully supported using the cloud integration and its automatic discovery.

Right now, manual setup isn't supported for formaldehyde devices because they're technically impossible to setup without using the cloud at least once (To my knowledge, there's no way to get their credentials without the cloud - they don't ship with the wifi sticker like older devices did). Other users (like over in the discussion on #20) have said that they saved credentials from the get_devices.py script and want to do a manual configuration, so that's something that I'm working out as well.

FYI, Formaldehyde devices were correctly output in the previous shenxn repo.

Ironically enough, despite some Formaldehyde devices being displayed in this list, the were not being properly supported and that's the main reason I created this fork. It was v0.18.0 of this repo that added universal support for Formaldehyde sensors.

But it's not shenxn's fault, it's actually Dyson's fault here. Feel free to read up from libdyson-neon #7 and this repo's #20 for more discussion, but it comes boils down to this:

Properly supporting Formaldehyde models actually happens to be one of the things I want to solve with a light refactor I'm working on right now. The challenge here is this: Dyson dealt us a tricky hand with their product codes for Formaldehyde models. The code 527K is correct for BOTH the Formaldehyde and non-Formaldehyde Purifier Hot+Cool. It's the same for all the Formaldehyde models, including the Humidifier; they all have product code collisions with their basic counterparts.

Sadly, this made it impossible to support both Formaldehyde and non-Formaldehyde models which shared names. There were conflicting PRs against shenxn's libdyson repository adding different support for different versions of the 527k for example: 35 and 36

And further from #20

I don't see the 527K in the list when doing a manual setup, is it not added here yet ?

This is also due to the naming collision - right now, we're still using the original libdyson's one-to-one devoce-code/device-name assumptions as set up in const.py. I want to make it more dynamic to allow for shared product codes.

I haven't had a lot of time lately (major life events happening, but this too shall pass) but pulling apart that forced-one-to-one relationship between device names and device codes is totally on the roadmap.


TL;DR: Shen's repository didn't actually support formaldehyde devices universally, and the individual Formaldehyde devices it did support actually broke support for their non-Formaldehyde equivalents. You can use https://github.com/libdyson-wg/ha-dyson-cloud to add your device. Let me know if you have any issues getting that to work of course, happy to help!

@dotvezz
Copy link
Member

dotvezz commented Jul 10, 2023

Hey @emagnier! This is sort of relevant to your issue, so I wanted to let you know there's a poll I opened over here: #49

@dotvezz
Copy link
Member

dotvezz commented Sep 8, 2023

Closing this one. Manual-only configuration of this generation of devices (HP07/09 and other devices released in late 2021 through 2022) is unfortunately still too messy due to model code conflicts. After merging the cloud features, the best way is to use a MyDyson account to automatically configure.

I don't want to prevent discussion though. If you have any concerns or questions, feel free to follow up here!

@dotvezz dotvezz closed this as completed Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants