Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply force to bodies added before attractor #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Apply force to bodies added before attractor #5

wants to merge 1 commit into from

Conversation

jpagand
Copy link

@jpagand jpagand commented Oct 2, 2017

When you add bodies before the attractor, they will have no force applied.
You were applying force only to bodies of index attractor + 1

@jpagand
Copy link
Author

jpagand commented Oct 4, 2017

hey @liabru did you have time to review this?

@jpagand jpagand mentioned this pull request Oct 12, 2017
Open
@francoispeyret
Copy link

francoispeyret commented Mar 27, 2021 •
edited
Loading

When you add bodies before the attractor, they will have no force applied.
You were applying force only to bodies of index attractor + 1

Hi, your modification on one of my test (with the "for" modified and the condition added) gives no change. Is it still working for you?

EDIT :
It works well, my test was not effective! 👍

@bits-by-brandon
Copy link

@liabru I think this change would unblock a project i'm working on. Any chance this could be merged in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpagand @francoispeyret @bits-by-brandon