Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Augmentation's randomness in classification code #75

Open
baek85 opened this issue Feb 24, 2024 · 1 comment
Open

Augmentation's randomness in classification code #75

baek85 opened this issue Feb 24, 2024 · 1 comment

Comments

@baek85
Copy link

baek85 commented Feb 24, 2024

Before asking my question, thank you for sharing your work!

I found that color augmentation is deterministic in your classification code.

In classification code(cls/dalib/modules/masking.py line 100-109), self.augmentation_params['color_jitter'] and self.augmentation_params['blur'] is sampled only at initialization of Masking class.
But, these parameters are related to randomness of augmentations(color jittering and gaussian blur).

I guess these parameters' sampling should be done in every forward step as with segmentation code(seg/mmseg/model/uda/masking_consistency_module.py line 119-128)

Thanks for your help

@lhoyer
Copy link
Owner

lhoyer commented Jun 9, 2024

Hi @baek85,

Thank you for your interest in our work!

Yes, your are right. This is indeed an unintended behavior. However, to ensure consistency of the published results and provided source code, we have decided to keep the current version.

Best,
Lukas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants