Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing the image before push it to docker hub #4

Open
nilodna opened this issue Aug 2, 2022 · 0 comments
Open

Testing the image before push it to docker hub #4

nilodna opened this issue Aug 2, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@nilodna
Copy link
Contributor

nilodna commented Aug 2, 2022

Before push it the already build image to docker hub, it might be necessary to test this image, by running a simplified upwelling test case. We have two choices here: 1) create the configuration files in this repository or 2) clone the experiment1 from roms_idealized_experiments, developed by @dksasaki.

It is mandatory, however, that we edit the .in file to change the integration time to something shorter (perhaps using sed), to shorten the building time in the GitHub action.

Another important point to consider here is that we must download the ROMS source code before running any application inside the container, so we will have to set some ROMS credentials as repository variables. Perhaps, just by downloading the source code, it is possible to copy the upwelling test case, edit what must be edited, and run the application without any new file here in this repository.

How to check if the application runs properly inside the container?
To check if the applications run properly, an idea is to save the output of the running to a file and check if the last lines of this logfile have the specific text (ROMS/TOMS: DONE...). Once this information is found in the log file, then we are able to push a tested image to the docker hub.

What I believe is the right template to insert into the workflow
We could use something similar to:

test:
    runs-on: ubuntu-latest
    steps:
      - name: Testing Container with Upwelling experiment
        run: |
            git clone https://<ROMS_USER_CRED>@www.myroms.org/git/src src_code
            mkdir -p test/upwelling
           cp src_code/External/ ... test/upwelling
@nilodna nilodna added the enhancement New feature or request label Aug 2, 2022
@nilodna nilodna self-assigned this Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant