Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view -s FLOAT only works for 0.5 or below #19

Open
avilella opened this issue Apr 24, 2013 · 1 comment
Open

view -s FLOAT only works for 0.5 or below #19

avilella opened this issue Apr 24, 2013 · 1 comment

Comments

@avilella
Copy link

As far as I can tell, the -s FLOAT option only works for values of float where the decimal is equal or below .5, due to this commented line in the code:
int x = (int)(g_subsam + .499);
/* int x = (int)g_subsam; *?

The commented version below allows, again as far as I can tell, to subsample, say, 90%, by speciying "-s 0.9" or "-s 123456.99" with a different seed.

Please confirm if this fixes it or if it will affect the outcome in a weird way.

Thanks,

Albert.

@avilella
Copy link
Author

Hmmmm, it seems this is implemented differently and fixed in 0.1.19. Feel free to ignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant