Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEGA65: VIC-IV RRB transparency issue #407

Closed
RetroCogs opened this issue Aug 21, 2024 · 2 comments · Fixed by #409
Closed

MEGA65: VIC-IV RRB transparency issue #407

RetroCogs opened this issue Aug 21, 2024 · 2 comments · Fixed by #409

Comments

@RetroCogs
Copy link
Contributor

Describe the bug
When using RRB and setting transparency using GOTOX, once transparency is set it cannot be unset for that line.

Used version of the project
Observed on version 20240620201019 next

To Reproduce
Using RRB, set transparency using color ram byte 0-bit7 and draw a character, then clear transparency using color ram byte 0-bit7.

You will notice that the following RRB chars are still transparent.

Expected behavior
Setting / clearing color ram byte0-bit7 when GOTOX is set should correctly switch between transparent and opaque.

Screenshots
Showing the sample program on Emu showing the issue.

image

Showing the sample program on HW with correct behavior.

image

Computer/Device (please complete the following information):

  • Mac
  • Sonoma 14.6.1

Additional context
Add any other context about the problem here.

@lgblgblgb
Copy link
Owner

As I've written on Discord: Great, thanks! As far as I can see, this is a kind of problem we had before; only setting/resetting a thing on GOTOX token but missing the "else" branch for the opposite.

@lgblgblgb
Copy link
Owner

@RetroCogs I cannot test this patch too much right now, but judging by the diff, it's quite trivial to understand what it does and how, so I think it's safe to be merged by me right now. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

2 participants