Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates and cleanups for building the extension #171

Merged
merged 2 commits into from
Jul 25, 2024
Merged

Updates and cleanups for building the extension #171

merged 2 commits into from
Jul 25, 2024

Conversation

petervdonovan
Copy link
Contributor

This silences certain compilation warnings and updates CONTRIBUTING.md.

Fixes #168.

@petervdonovan petervdonovan requested a review from lhstrh July 24, 2024 20:45
@petervdonovan petervdonovan mentioned this pull request Jul 24, 2024
Merged
lhstrh
lhstrh approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks for these fixes!

@lhstrh lhstrh merged commit 9147d7c into main Jul 25, 2024
3 checks passed
@lhstrh lhstrh deleted the clean-up-build branch July 25, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

npm run compile fails on main
2 participants
@petervdonovan @lhstrh